Skip to content

fix: helper insertion, loader runtime web targets. - #58

Merged
knightedcodemonkey merged 3 commits into
mainfrom
bananas
Jan 4, 2026
Merged

fix: helper insertion, loader runtime web targets.#58
knightedcodemonkey merged 3 commits into
mainfrom
bananas

Conversation

@knightedcodemonkey

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings January 4, 2026 18:48
@codecov

codecov Bot commented Jan 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.55%. Comparing base (5eb25d3) to head (b0f0197).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/loader/jsx.ts 94.73% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   89.43%   89.55%   +0.12%     
==========================================
  Files          15       15              
  Lines        1467     1484      +17     
  Branches      394      399       +5     
==========================================
+ Hits         1312     1329      +17     
  Misses         39       39              
  Partials      116      116              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes helper insertion in the JSX loader by hoisting React helper functions to the beginning of transformed modules instead of appending them at the end. The change includes a new test to verify the hoisting behavior, version bumps from release candidates to stable releases, clean script improvements, and new documentation for React SSR usage.

Key Changes:

  • Helper functions (__jsxReact, __jsxReactMergeProps) are now prepended to the beginning of files (after any shebang) instead of being appended at the end
  • Version bumped from 1.6.3-rc.1 to 1.6.3 with dependency updates
  • New SSR documentation guide added

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/loader/jsx.ts Changes helper insertion from append() to prepend() with shebang handling
test/loader.test.ts Adds test to verify helpers are hoisted before transformed templates
package.json Version bump to 1.6.3, dependency updates, and clean script improvements
package-lock.json Lockfile updates for version and dependency changes
docs/ssr-rendered-bundle.md New documentation guide for React SSR with the JSX loader

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/ssr-rendered-bundle.md Outdated
Comment thread docs/ssr-rendered-bundle.md Outdated
Comment thread src/loader/jsx.ts
@knightedcodemonkey knightedcodemonkey changed the title fix: helper insertion. fix: helper insertion, loader runtime web targets. Jan 4, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/loader/jsx.ts Outdated
@knightedcodemonkey
knightedcodemonkey merged commit 4eba1d1 into main Jan 4, 2026
7 checks passed
@knightedcodemonkey
knightedcodemonkey deleted the bananas branch January 4, 2026 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants