Skip to content

新增新功能并解决存在的bug#163

Open
liaomengge wants to merge 4 commits into
knightliao:devfrom
liaomengge:master
Open

新增新功能并解决存在的bug#163
liaomengge wants to merge 4 commits into
knightliao:devfrom
liaomengge:master

Conversation

@liaomengge

Copy link
Copy Markdown

为了方便更多用户的管理,针对源码做了如下修改:

  1. 新增用户注册功能
  2. 增加用户与App绑定
  3. 修正更新配置文件,发送邮件(可能很慢),导致修改事务失败
  4. 开启用户修改密码(之前好像有权限限制)

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 42.271% when pulling c64366f on liaomengge:master into e553fab on knightliao:dev.


String ownAppIds = user.getOwnApps();
if ("admin".equals(user.getName())) {
if ("admin".equals(user.getName()) && StringUtils.isNotBlank(ownAppIds)) {

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不要用admin字符进行判断是否是管理员

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"admin"只是一个很特殊的用户,而并不是简单的管理员,这样做,是将admin唯一的管理员权限,下发到各个部门各自有自己的管理,这样便于脱离"中心管理",当然也可以去掉这个特殊情况,但是这样,就没有一个整体的管控了、、、

@knightliao

Copy link
Copy Markdown
Owner

需要进行优化下

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.02%) to 42.293% when pulling a9c8403 on liaomengge:master into e553fab on knightliao:dev.

user.setToken(SignUtils.createToken(regUserName));
user.setOwnApps("0");
//此处给管理员的权限,就是为了admin中心权限,下方到各个部门权限
user.setRoleId(RoleEnum.ADMIN.getValue());

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这样以后所有注册的用户都是管理员了?
下门到各个部分权限的意思是?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants