Skip to content

UIEXT-3492: Wait: Hide local file option in remote context #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PaulBrnrther wants to merge 1 commit into
base: master
Choose a base branch
from
Open

UIEXT-3492: Wait: Hide local file option in remote context #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
98 changes: 32 additions & 66 deletions ...s/files/test_snapshots/org.knime.base.node.flowcontrol.sleep.SleepNodeParametersTest.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@
"toHours" : 0,
"toMinutes" : 0,
"toSeconds" : 0,
"filePath" : "",
"fileEvent" : "MODIFICATION"
"localFsWarning" : { }
}
},
"schema" : {
Expand All @@ -19,27 +18,6 @@
"model" : {
"type" : "object",
"properties" : {
"fileEvent" : {
"oneOf" : [ {
"const" : "MODIFICATION",
"title" : "Modified"
}, {
"const" : "CREATION",
"title" : "Created"
}, {
"const" : "DELETION",
"title" : "Deleted"
} ],
"title" : "File change",
"description" : "Type of file event to wait for.\n<ul>\n<li><b>Modified</b>: Waits until the specified file is modified.</li>\n<li><b>Created</b>: Waits until the specified file is created.</li>\n<li><b>Deleted</b>: Waits until the specified file is deleted.</li>\n</ul>",
"default" : "MODIFICATION"
},
"filePath" : {
"type" : "string",
"title" : "File",
"description" : "Path to the file to monitor for events. Can be a local file or URL pointing to a local file.",
"default" : ""
},
"forHours" : {
"type" : "integer",
"format" : "int32",
Expand Down Expand Up @@ -68,6 +46,18 @@
"description" : "The amount of seconds to wait for.",
"default" : 1
},
"localFsWarning" : {
"type" : "object",
"properties" : {
"message" : {
"type" : "object"
},
"title" : {
"type" : "string"
}
},
"default" : { }
},
"toHours" : {
"type" : "integer",
"format" : "int32",
Expand Down Expand Up @@ -96,12 +86,9 @@
}, {
"const" : "WAIT_UNTIL_TIME",
"title" : "To time of day"
}, {
"const" : "WAIT_FILE",
"title" : "For file change"
} ],
"title" : "Wait",
"description" : "Select how the node should wait: for a duration, until a specific time, or for a file event.\n<ul>\n<li><b>For duration</b>: The node waits for the entered duration (hour, minute, second, millisecond).</li>\n<li><b>To time of day</b>: The node waits until the entered time of day is reached (hour, minute, second).</li>\n<li><b>For file change</b>: The node waits until the selected file (or URL that\npoints to a local file) either gets created, modified or deleted.\n</li>\n</ul>",
"description" : "Select how the node should wait: for a duration, until a specific time, or for a file event.\n<ul>\n<li><b>For duration</b>: The node waits for the entered duration (hour, minute, second, millisecond).</li>\n<li><b>To time of day</b>: The node waits until the entered time of day is reached (hour, minute, second).</li>\n</ul>",
"default" : "WAIT_FOR_TIME"
}
}
Expand Down Expand Up @@ -342,41 +329,11 @@
}
}, {
"type" : "Control",
"scope" : "#/properties/model/properties/filePath",
"options" : {
"fileSystem" : "LOCAL",
"isLocal" : true,
"selectionMode" : "FILE_OR_FOLDER",
"format" : "stringFileChooser"
},
"rule" : {
"effect" : "SHOW",
"condition" : {
"scope" : "#/properties/model/properties/waitMode",
"schema" : {
"oneOf" : [ {
"const" : "WAIT_FILE"
} ]
}
}
}
}, {
"type" : "Control",
"scope" : "#/properties/model/properties/fileEvent",
"id" : "#/properties/model/properties/localFsWarning/properties/message",
"options" : {
"format" : "valueSwitch"
"format" : "textMessage"
},
"rule" : {
"effect" : "SHOW",
"condition" : {
"scope" : "#/properties/model/properties/waitMode",
"schema" : {
"oneOf" : [ {
"const" : "WAIT_FILE"
} ]
}
}
}
"providedOptions" : [ "message" ]
} ]
},
"persist" : {
Expand Down Expand Up @@ -409,14 +366,23 @@
"toSeconds" : {
"configKey" : "to_seconds"
},
"filePath" : {
"configKey" : "path_to_file"
},
"fileEvent" : {
"configPaths" : [ [ "file_status_to_observe" ] ]
"localFsWarning" : {
"propertiesConfigPaths" : [ ],
"propertiesRoute" : [ ".." ],
"deprecatedConfigKeys" : [ {
"deprecated" : [ ]
} ]
}
}
}
}
}
},
"initialUpdates" : [ {
"id" : "#/properties/model/properties/localFsWarning/properties/message",
"providedOptionName" : "message",
"values" : [ {
"indices" : [ ],
"value" : null
} ]
} ]
}
2 changes: 0 additions & 2 deletions ...napshots/org.knime.base.node.flowcontrol.sleep.SleepNodeParametersTest0.settings.xml.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,4 @@
<entry key="to_hours" type="xint" value="0"/>
<entry key="to_min" type="xint" value="0"/>
<entry key="to_seconds" type="xint" value="0"/>
<entry key="path_to_file" type="xstring" value=""/>
<entry key="file_status_to_observe" type="xstring" value="Modification"/>
</config>
98 changes: 32 additions & 66 deletions .../files/test_snapshots/org.knime.base.node.flowcontrol.sleep.SleepNodeParametersTest1.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@
"toHours" : 0,
"toMinutes" : 0,
"toSeconds" : 0,
"filePath" : "",
"fileEvent" : "MODIFICATION"
"localFsWarning" : { }
}
},
"schema" : {
Expand All @@ -19,27 +18,6 @@
"model" : {
"type" : "object",
"properties" : {
"fileEvent" : {
"oneOf" : [ {
"const" : "MODIFICATION",
"title" : "Modified"
}, {
"const" : "CREATION",
"title" : "Created"
}, {
"const" : "DELETION",
"title" : "Deleted"
} ],
"title" : "File change",
"description" : "Type of file event to wait for.\n<ul>\n<li><b>Modified</b>: Waits until the specified file is modified.</li>\n<li><b>Created</b>: Waits until the specified file is created.</li>\n<li><b>Deleted</b>: Waits until the specified file is deleted.</li>\n</ul>",
"default" : "MODIFICATION"
},
"filePath" : {
"type" : "string",
"title" : "File",
"description" : "Path to the file to monitor for events. Can be a local file or URL pointing to a local file.",
"default" : ""
},
"forHours" : {
"type" : "integer",
"format" : "int32",
Expand Down Expand Up @@ -68,6 +46,18 @@
"description" : "The amount of seconds to wait for.",
"default" : 1
},
"localFsWarning" : {
"type" : "object",
"properties" : {
"message" : {
"type" : "object"
},
"title" : {
"type" : "string"
}
},
"default" : { }
},
"toHours" : {
"type" : "integer",
"format" : "int32",
Expand Down Expand Up @@ -96,12 +86,9 @@
}, {
"const" : "WAIT_UNTIL_TIME",
"title" : "To time of day"
}, {
"const" : "WAIT_FILE",
"title" : "For file change"
} ],
"title" : "Wait",
"description" : "Select how the node should wait: for a duration, until a specific time, or for a file event.\n<ul>\n<li><b>For duration</b>: The node waits for the entered duration (hour, minute, second, millisecond).</li>\n<li><b>To time of day</b>: The node waits until the entered time of day is reached (hour, minute, second).</li>\n<li><b>For file change</b>: The node waits until the selected file (or URL that\npoints to a local file) either gets created, modified or deleted.\n</li>\n</ul>",
"description" : "Select how the node should wait: for a duration, until a specific time, or for a file event.\n<ul>\n<li><b>For duration</b>: The node waits for the entered duration (hour, minute, second, millisecond).</li>\n<li><b>To time of day</b>: The node waits until the entered time of day is reached (hour, minute, second).</li>\n</ul>",
"default" : "WAIT_FOR_TIME"
}
}
Expand Down Expand Up @@ -342,41 +329,11 @@
}
}, {
"type" : "Control",
"scope" : "#/properties/model/properties/filePath",
"options" : {
"fileSystem" : "LOCAL",
"isLocal" : true,
"selectionMode" : "FILE_OR_FOLDER",
"format" : "stringFileChooser"
},
"rule" : {
"effect" : "SHOW",
"condition" : {
"scope" : "#/properties/model/properties/waitMode",
"schema" : {
"oneOf" : [ {
"const" : "WAIT_FILE"
} ]
}
}
}
}, {
"type" : "Control",
"scope" : "#/properties/model/properties/fileEvent",
"id" : "#/properties/model/properties/localFsWarning/properties/message",
"options" : {
"format" : "valueSwitch"
"format" : "textMessage"
},
"rule" : {
"effect" : "SHOW",
"condition" : {
"scope" : "#/properties/model/properties/waitMode",
"schema" : {
"oneOf" : [ {
"const" : "WAIT_FILE"
} ]
}
}
}
"providedOptions" : [ "message" ]
} ]
},
"persist" : {
Expand Down Expand Up @@ -409,14 +366,23 @@
"toSeconds" : {
"configKey" : "to_seconds"
},
"filePath" : {
"configKey" : "path_to_file"
},
"fileEvent" : {
"configPaths" : [ [ "file_status_to_observe" ] ]
"localFsWarning" : {
"propertiesConfigPaths" : [ ],
"propertiesRoute" : [ ".." ],
"deprecatedConfigKeys" : [ {
"deprecated" : [ ]
} ]
}
}
}
}
}
},
"initialUpdates" : [ {
"id" : "#/properties/model/properties/localFsWarning/properties/message",
"providedOptionName" : "message",
"values" : [ {
"indices" : [ ],
"value" : null
} ]
} ]
}
Loading