Enh/UI ext 3514 web UI migration window loop start#177
Open
jannik-sem wants to merge 1 commit intomasterfrom
Open
Enh/UI ext 3514 web UI migration window loop start#177jannik-sem wants to merge 1 commit intomasterfrom
jannik-sem wants to merge 1 commit intomasterfrom
Conversation
jannik-sem
requested review from
Copilot and
knime-ghub-bot
and removed request for
Copilot
jannik-sem
force-pushed
the
enh/UIEXT-3514-WebUI-Migration-Window-Loop-Start
branch
2 times, most recently
from
1c955c1 to
016ca2d
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the Window Loop Start node to the Web UI/default dialog stack by introducing a NodeParameters model, generating node description programmatically, and adding snapshot coverage for the new parameters-based dialog/settings persistence.
Changes:
- Added
LoopStartWindowNodeParameterswith Web UI widget metadata and custom persistors for legacy settings compatibility. - Updated
LoopStartWindowNodeFactoryto provide a Web UI dialog (DefaultNodeDialog), Kai interface, and generatedNodeDescription; removed the legacyLoopStartWindowNodeFactory.xml. - Added snapshot tests + baseline node-settings XML and expected snapshot outputs for the new parameters model.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| org.knime.time/src/org/knime/time/node/window/LoopStartWindowNodeParameters.java | New Web UI parameters model incl. persistence/migration logic for legacy settings keys. |
| org.knime.time/src/org/knime/time/node/window/LoopStartWindowNodeFactory.java | Switches factory to Web UI dialog, Kai interface, and programmatic node description. |
| org.knime.time/src/org/knime/time/node/window/LoopStartWindowNodeFactory.xml | Removes legacy XML node description (superseded by generated description). |
| org.knime.time.tests/src/org/knime/time/node/window/LoopStartWindowNodeParametersTest.java | Adds snapshot test for the new parameters model. |
| org.knime.time.tests/files/test_snapshots/org.knime.time.node.window.LoopStartWindowNodeParametersTest*.snap | Snapshot baselines for JSON forms/schema/persist mapping. |
| org.knime.time.tests/files/test_snapshots/org.knime.time.node.window.LoopStartWindowNodeParametersTest0.settings.xml.snap | Snapshot baseline for settings XML structure. |
| org.knime.time.tests/files/node_settings/LoopStartWindowNodeParameters.xml | Input settings used by the snapshot test. |
| org.knime.base.tests/files/node_settings/LoopStartWindowNodeParameters.xml | Additional baseline node-settings file for broader test coverage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jannik-sem
force-pushed
the
enh/UIEXT-3514-WebUI-Migration-Window-Loop-Start
branch
4 times, most recently
from
e9f5990 to
85486d1
Compare
mgohm
requested changes
Apr 7, 2026
jannik-sem
force-pushed
the
enh/UIEXT-3514-WebUI-Migration-Window-Loop-Start
branch
from
7c7b8ef to
8eee501
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mgohm
requested changes
Apr 12, 2026
jannik-sem
force-pushed
the
enh/UIEXT-3514-WebUI-Migration-Window-Loop-Start
branch
from
01ca391 to
477dac3
Compare
mgohm
force-pushed
the
enh/UIEXT-3514-WebUI-Migration-Window-Loop-Start
branch
from
477dac3 to
5841799
Compare
|
UIEXT-3514 (WebUI-Migration Window Loop Start)
mgohm
force-pushed
the
enh/UIEXT-3514-WebUI-Migration-Window-Loop-Start
branch
from
f8847e8 to
8609496
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.