NXT-4596: Add BrowserService interface and OSGi service tracker#135
Open
hornm-knime wants to merge 2 commits intomasterfrom
Open
NXT-4596: Add BrowserService interface and OSGi service tracker#135hornm-knime wants to merge 2 commits intomasterfrom
hornm-knime wants to merge 2 commits intomasterfrom
Conversation
hornm-knime
requested review from
Copilot and
knime-ghub-bot
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
Introduces an OSGi-discoverable BrowserService API in org.knime.core.ui to generate static artifacts (images/reports/PDF) via a headless browser, supporting the effort to move Equo Chromium usage out of the Executor.
Changes:
- Add new
BrowserServiceinterface for headless rendering/printing and a convenienceBrowserService.get()lookup. - Track
BrowserServicevia an OSGiServiceTrackerinCoreUIPluginand expose it throughCoreUIPlugin.getBrowserService(). - Export new internal package
org.knime.core.webui.browserfrom the bundle.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
org.knime.core.ui/src/eclipse/org/knime/core/webui/browser/BrowserService.java |
Adds the BrowserService API for rendering images/reports and printing PDFs, plus a static lookup helper. |
org.knime.core.ui/src/eclipse/org/knime/core/ui/CoreUIPlugin.java |
Adds a ServiceTracker and static accessor for retrieving the active BrowserService. |
org.knime.core.ui/META-INF/MANIFEST.MF |
Exports the new internal browser package so it can be referenced within the platform. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| * @since 5.12 | ||
| */ | ||
| public static Optional<BrowserService> getBrowserService() { | ||
| return Optional.ofNullable(instance.m_browserServiceTracker).map(ServiceTracker::getService); |
Comment on lines
80
to
+83
| public void stop(final BundleContext context) throws Exception { | ||
| // | ||
| m_browserServiceTracker.close(); | ||
| m_browserServiceTracker = null; | ||
| instance = null; |
hornm-knime
force-pushed
the
todo/NXT-4596-move-equo-chromium-out-of-the-executor
branch
from
7f195fc to
c01e2ca
Compare
hornm-knime
force-pushed
the
todo/NXT-4596-move-equo-chromium-out-of-the-executor
branch
2 times, most recently
from
2a1ade0 to
f48ae8c
Compare
NXT-4596 (Move Equo Chromium out of the Executor)
hornm-knime
force-pushed
the
todo/NXT-4596-move-equo-chromium-out-of-the-executor
branch
from
f48ae8c to
a05ffed
Compare
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NXT-4596 (Move Equo Chromium out of the Executor)