Skip to content

Fix v-calendar source URL and eliminate excessive Vue console warnings during tests#147

Draft
Copilot wants to merge 2 commits intomasterfrom
copilot/analyze-console-logs
Draft

Fix v-calendar source URL and eliminate excessive Vue console warnings during tests#147
Copilot wants to merge 2 commits intomasterfrom
copilot/analyze-console-logs

Conversation

Copy link
Copy Markdown

Copilot AI commented Mar 24, 2026

Tests in org.knime.core.ui/js-src were generating hundreds of suppressed [Vue warn] messages, causing excessive memory consumption during pnpm coverage. The onConsoleLog filter in vite.config.ts was masking real issues. This PR fixes the dependency source and the underlying causes of the most prolific warnings.

Dependency fix

  • pnpm-lock.yaml: Replace broken https://bitbucket.org/KNIME/v-calendar/get/048477f.tar.gz with https://codeload.github.com/knime/v-calendar/tar.gz/048477f (same commit, Bitbucket no longer accessible). Removes the duplicate orphaned entry.

Vue warning fixes

ArrayLayoutItem.vue — "Missing required prop: subTitleProvider" (×174)

subTitleProvider: string | undefined was treated as required by Vue (only ? makes a prop optional in defineProps<{}>):

// before
subTitleProvider: string | undefined;
// after
subTitleProvider?: string;

ArrayLayout.test.js — "Invalid prop: id got Undefined" (×168)

Test data lacked _id fields that ArrayLayout.vue passes as the required id prop. The mocked handleChange never populated them reactively, so added _id: "id-N" directly to each fixture item.

ArrayLayout.test.js — missing injection warnings (×302 combined)

addStateProviderListener and trigger were absent from mountArrayLayout's default provide, causing injection-not-found warnings in every test that exercised array items. Added both as vi.fn() defaults.

composables/index.ts — "injection Symbol(arrayParentScope) not found" (×144)

Vue warns even when the caller handles undefined via ??. Switching to the built-in default parameter silences the warning at the source:

// before
const parentScope = vueInject(injectionKeyParentScope) ?? arrayScope;
// after
const parentScope = vueInject(injectionKeyParentScope, arrayScope);

Remaining warnings (not yet addressed)

  • title / enableDataValueViews prop-type warnings from TableViewInteractive tests (×125 each)
  • Readonly-ref write warnings in flow variable tests (×343)
  • applyData / getData injection warnings (×46)
  • onConsoleLog suppression in vite.config.ts should be removed once all warnings are resolved

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • bitbucket.org
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/_temp/ghcca-node/node/bin/pnpm install (dns block)
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/_temp/ghcca-node/node/bin/pnpm install --prefer-offline (dns block)
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/_temp/ghcca-node/node/bin/pnpm install --ignore-scripts --frozen-lockfile (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

Copilot AI changed the title [WIP] Analyze excessive console log output during tests Fix v-calendar source URL and eliminate excessive Vue console warnings during tests Mar 24, 2026
Copilot AI requested a review from ChristianAlbrecht March 24, 2026 12:06
Copilot AI and others added 2 commits April 1, 2026 17:11
…d.github.com) URL in pnpm-lock.yaml

Co-authored-by: ChristianAlbrecht <8696495+ChristianAlbrecht@users.noreply.github.com>
Agent-Logs-Url: https://github.com/knime/knime-core-ui/sessions/b4d257bb-95fd-452e-82b3-0439297dfa1b
…a, provide missing injections, fix arrayParentScope inject default

Co-authored-by: ChristianAlbrecht <8696495+ChristianAlbrecht@users.noreply.github.com>
Agent-Logs-Url: https://github.com/knime/knime-core-ui/sessions/b4d257bb-95fd-452e-82b3-0439297dfa1b
@ChristianAlbrecht ChristianAlbrecht force-pushed the copilot/analyze-console-logs branch from 3428f05 to 0a2c764 Compare April 1, 2026 15:11
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 1, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants