Enh/kds 791 use error message from component#191
Open
robin-gerling wants to merge 1 commit intomasterfrom
Open
Enh/kds 791 use error message from component#191robin-gerling wants to merge 1 commit intomasterfrom
robin-gerling wants to merge 1 commit intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the table creator dialog to rely on KDS component-provided error display/spacings (instead of custom error message components/CSS), and aligns several inputs with @knime/kds-components.
Changes:
- Removed the custom table-creator error message components (
ErrorMessages.vue,ErrorLine.vue) and their shared CSS variables (error-messages.css). - Migrated table creator inputs to KDS equivalents (e.g.,
KdsTextInput,KdsTextarea,KdsDropdown) and wired error display via component props (error,sub-text). - Adjusted spacing in related node dialog UI components to match KDS label spacing expectations.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
.../tableCreatorDialog/components/errorMessage/error-messages.css |
Removed global CSS custom properties used for error-message spacing. |
.../tableCreatorDialog/components/errorMessage/ErrorMessages.vue |
Removed wrapper component that rendered multiple error lines below fields. |
.../tableCreatorDialog/components/errorMessage/ErrorLine.vue |
Removed single-line error renderer with icon and ellipsis behavior. |
.../tableCreatorDialog/components/DataTypeDropdown.vue |
Switched to KdsDropdown and mapped options using accessory. |
.../tableCreatorDialog/components/ColumnNameInput.vue |
Switched to KdsTextInput and uses error/sub-text instead of custom error slotting. |
.../tableCreatorDialog/components/ColumnHeaderInput.vue |
Removed import of the error-message CSS and simplified padding/gap. |
.../tableCreatorDialog/components/CellInput.vue |
Switched to KdsTextarea and adjusted value-switch sizing. |
.../nodeDialog/uiComponents/flowVariables/components/FlowVariableButtonWrapper.vue |
Added bottom spacing via a wrapper class to match input label spacing. |
.../nodeDialog/uiComponents/description/DescriptionPopover.vue |
Added bottom spacing to align with the same label spacing pattern. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
... and replace input fields by KDS input fields KDS-791 (Use error message from component instead of custom implementation)
robin-gerling
force-pushed
the
enh/KDS-791-use-error-message-from-component
branch
from
7dc0c9a to
5e7a2e6
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.