Skip to content

HUB-9592: Add ENV variables to configure NodeLogger#89

Open
enplotz wants to merge 1 commit intomasterfrom
todo/HUB-9592-ec-log-level
Open

HUB-9592: Add ENV variables to configure NodeLogger#89
enplotz wants to merge 1 commit intomasterfrom
todo/HUB-9592-ec-log-level

Conversation

@enplotz
Copy link
Copy Markdown
Contributor

@enplotz enplotz commented Apr 7, 2026

Adding ENV variables so we can reference them in dependent plugins, e.g. workbench preferences which defines the "single source of truth" for runtime logging configuration we use.

Even though the NodeLogger and NodeLoggerConfig offer API to configure it, any modification will not be synced back to the Workbench preferences, which is confusing (since users don't see it reflected in the Preferences dialog) and error prone.

HUB-9592 (Add log level setting to EC configuration)

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces new environment variables (and corresponding Java system properties) to configure default NodeLogger log levels and workflow logging behavior via external configuration, aligning with HUB-9592’s goal of making log level settings configurable in EC deployments.

Changes:

  • Added environment variable constants for configuring minimum log levels for stdout, global logfile, and workflow logging.
  • Added environment variable + Java system property constants to enable/disable workflow logging by default.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread org.knime.core/src/eclipse/org/knime/core/node/KNIMEConstants.java Outdated
Comment thread org.knime.core/src/eclipse/org/knime/core/node/KNIMEConstants.java Outdated
@enplotz enplotz force-pushed the todo/HUB-9592-ec-log-level branch from 0df82a9 to af29342 Compare April 7, 2026 12:24
HUB-9592 (Add log level setting to EC configuration)
@enplotz enplotz force-pushed the todo/HUB-9592-ec-log-level branch from af29342 to c2efd17 Compare April 7, 2026 14:45
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 7, 2026

@enplotz enplotz requested a review from bernd-wiswedel April 8, 2026 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants