Skip to content

UIEXT-3497: Allow modification of dbName for DBConnectors#95

Open
tcrundall-tng wants to merge 1 commit intomasterfrom
enh/UIEXT-3497-webui-migration-amazon-athena-connector
Open

UIEXT-3497: Allow modification of dbName for DBConnectors#95
tcrundall-tng wants to merge 1 commit intomasterfrom
enh/UIEXT-3497-webui-migration-amazon-athena-connector

Conversation

@tcrundall-tng
Copy link
Copy Markdown
Contributor

  • Athena Connector does not use DBName so needs to hide it

UIEXT-3497 (WebUI-Migration Amazon Athena Connector)

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a widget reference for the server-connector “Database name” parameter so downstream Modification.Modifiers can hide or adjust the UI for connectors where a database name is not applicable (e.g., Athena).

Changes:

  • Annotate m_databaseName with @Modification.WidgetReference(...) to enable targeted UI modification.
  • Introduce DatabaseNameRef as a Modification.Reference for the database-name widget.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tcrundall-tng tcrundall-tng force-pushed the enh/UIEXT-3497-webui-migration-amazon-athena-connector branch from 3b6c404 to adadd3f Compare March 30, 2026 15:03
@jannik-loescher-knime jannik-loescher-knime force-pushed the enh/UIEXT-3497-webui-migration-amazon-athena-connector branch from adadd3f to 5ea45fe Compare April 2, 2026 06:50
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 2, 2026

* Athena Connector does not use DBName so needs to hide it

UIEXT-3497 (WebUI-Migration Amazon Athena Connector)
@jannik-loescher-knime jannik-loescher-knime force-pushed the enh/UIEXT-3497-webui-migration-amazon-athena-connector branch from 5ea45fe to f92c67a Compare April 2, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants