fix(KNO-10099): support passing api-origin flag to knock push and pull #634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjbell
approved these changes
Oct 14, 2025
mattmikolay
deleted the
mattmik-kno-10099-cli-knock-push-and-knock-pull-commands-do-not-support-api
branch
connorlindsey
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All of our CLI commands support passing in a hidden
--api-originflag:knock-cli/src/lib/base-command.ts
Lines 162 to 167 in d7034da
But the
knock pushandknock pullcommands currently fail to forward this flag when calling the resource-specific push/pull commands. This PR fixes these commands.I tried updating unit tests to verify this behavior, but there’s no simple way to test this using Sinon.
Tasks
KNO-10099