Skip to content

Update build process #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
brianmhunt wants to merge 54 commits into
base: main
Choose a base branch
from
Open

Update build process #111

brianmhunt wants to merge 54 commits into from

Conversation

@brianmhunt
Copy link
Member

@brianmhunt brianmhunt commented Apr 22, 2020 •
edited
Loading

This is a PR to update the build process since many of the dev dependencies were out of date, making merging e.g. #62 challenging.

brianmhunt and others added 18 commits April 22, 2020 09:12
@brianmhunt
ts) add ambient types as build stop-gap
12319ef
@brianmhunt
observable) update subscribable types
fbc0b99
@brianmhunt
observable) update extenders types
a713c1c
@brianmhunt
observable) update subscribable import/extender type
c11ceb4
@brianmhunt
tsconfig) set target to ES5, so we can use getters
ae5fa16
@brianmhunt
observable) add types for extenders and subscribable
eb1c005
@brianmhunt
app/observable) add to observable, extenders, other types
f2ef579
@brianmhunt
observable) break out limit and add more types
4e49192
@brianmhunt
observable) type the rate limiting; some observable/subscribable
11f454b
@brianmhunt
observable) re-order prototype property for proper typing
e352812
@brianmhunt
observable) fix KnockoutObservable types
5b485d4
@brianmhunt
observable) begin typing of observableArray
53d89c6
@brianmhunt
ts) target ES2020 modules
f18444c
@brianmhunt
observable) add more observableArray functionality
af8a340
@brianmhunt
computed) add arrayProperties extender
9084550
@brianmhunt
observable) finish observableArray types
21fd69b
@brianmhunt
observable) add typing to the changeTracking
983bf6e
@brianmhunt
computed) add some computed types
11f0395
brianmhunt and others added 25 commits April 29, 2020 08:49
@brianmhunt
computed) rename to .ts file
5f00475
@brianmhunt
computed) more typing of the computed
a021267
@brianmhunt
observable) expose the RateLimitFunction
2562e60
@brianmhunt
utils) convert options to ts
f645ff8
@brianmhunt
observable) fix some types
d3adfc5
@brianmhunt
options) add a __ko_proto__ type
fc2980c
@brianmhunt
computed) add more typing of the ko-computed
f46cb9b
@brianmhunt
observable) fix observableArray inheritance
b625594
@brianmhunt
npm) update packages to latest
6f8bde1
@brianmhunt
npm) change prepublish script to prepublishOnly
c4d4d06
@brianmhunt
observable) fix trackArrayChanges params
08c9f13
@brianmhunt
make) add lint target
70e5311
@brianmhunt
ts) narrow the tsconfig for building all files
3961955
@brianmhunt
observable/ts) various minor type updates
443bcd3
@brianmhunt
utils.jsx) numerous types
746b0cc
@brianmhunt
observable) update some key types (unwrap, peek)
3041499
@brianmhunt
provider.native) convert to TS
c0a593f
@brianmhunt
utils.jsx) add more types to the JsxObservaber
6b0efe1
@brianmhunt
observable) fix isObservable type guard
a0ac02d
@brianmhunt
utils.jsx) fix attribute unwrapping type
bfd67ae
@brianmhunt
tsconfig) add support for Object.fromEntries
5c30a5c
@brianmhunt
provider) type Provider; add types for NativeProvider
98c5904
@brianmhunt
observable) fix some observable types & array tracking types
a1c9e06
@brianmhunt
observable) add some proto types
74be7a2
@brianmhunt
computed) add more typings of the computed
1c799db
@brianmhunt brianmhunt mentioned this pull request May 24, 2021
Open
@brianmhunt brianmhunt mentioned this pull request Jun 20, 2021
Merged
@phillipc
Copy link
Member

phillipc commented Feb 28, 2025

Is this topic already settled with #195?

phillipc
phillipc reviewed Feb 28, 2025
View reviewed changes
packages/observable/src/subscribable.ts
next (value: T): void
}

export function subscribable<T> (this: KnockoutSubscribable<T>): KnockoutSubscribable<T> {
Copy link
Member

@phillipc phillipc Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some nice ts ports, many we could take up it again after merging #202.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phillipc phillipc phillipc left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brianmhunt @phillipc