jquery) Fix loading jquery and add tests #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lt options (useOnlyNativeEvents: true)
…ag to a new option / skip some tests if they do not match the selected options
…. After this fix, some bugs were discovered in the interaction with TKO, triggerEvent, and JQuery 3.7. With this PR, the tests are configured to run with and without JQuery. The detection and loading mechanism for JQuery has also been corrected, but it still relies on a global instance, which can also be set manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was previously no test setup that used JQuery correctly. After this was fixed, some bugs were discovered in the interaction with TKO, triggerEvent, and JQuery 3.7. With this PR, the tests are configured to run with and without JQuery. The detection and loading mechanism for JQuery has also been corrected, but it still relies on a global instance, which can also be set manually.