bugfix for keep alive zero#1038
Open
ChuckMash wants to merge 1 commit into
Open
Conversation
|
Hey @knolleary would you be able to review/merge this oneliner bugfix? |
|
Unfortunately there are so may undone pull requests here that one can believe that @knolleary dropped support of this repo. Maybe it's good to do a PR at https://github.com/thingsboard/pubsubclient as they promised to support development on this library. |
|
@hmueller01 opened a PR there: thingsboard#7 |
|
This is solved in https://github.com/hmueller01/pubsubclient3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting keep alive to 0, or infinite keep alive, is not currently handled correctly.
Currently the client will immediately disconnect when keep alive is set to 0, this fix adds a check for this state before attempting PINGREQ.
Solves #1033