Ajl/add comms metrics#989
Open
ajlennon wants to merge 2 commits into
Open
Conversation
_client->read() returns a signed int which can fail if the underlying stream is implemented as such.
e.g. TinyGsmTCP::read() is implemented to return a -1 on failure
int read() override {
uint8_t c;
if (read(&c, 1) == 1) { return c; }
return -1;
}
Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>
That this provides getTxCount() and getRxCount() which return the number of bytes transmitted to and received from the underlying stream by the MQTT implementation. Note that this does not include any additional TCP headers that may be added by the underlying implementation but it does give a useful starting point for datacomms. usage over time e.g. when using a cellular stream implementation such as TinyGSM Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>
ajlennon
added a commit
to DynamicDevices/TTGO-T-Call-PlatformIO
that referenced
this pull request
Dec 28, 2022
So for now we will use the private copy in this repo rather than pull from upstream. There's a PR here: knolleary/pubsubclient#989
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.