Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added attachment::Dbg #12

Merged
merged 6 commits into from
May 3, 2024
Merged

Added attachment::Dbg #12

merged 6 commits into from
May 3, 2024

Conversation

mkatychev
Copy link
Contributor

@mkatychev mkatychev commented Apr 29, 2024

Introduced attachment::Dbg to avoid prematurely allocating Strings through early format! calls.

  • Moved most Reportable method implementations out of reportable! and into blanket implementations under the trait proper.
  • Removed ResultAttachExt

@mergify mergify bot added the feature label Apr 29, 2024
@mkatychev mkatychev marked this pull request as ready for review April 30, 2024 04:41
Copy link
Contributor

@jsgoyette jsgoyette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Co-authored-by: Jeremiah Goyette <jsgoyette@protonmail.com>
@mergify mergify bot merged commit 78e88cb into main May 3, 2024
4 checks passed
@mergify mergify bot removed the automerge label May 3, 2024
@mergify mergify bot deleted the feat/dbg-object branch May 3, 2024 22:05
Copy link
Contributor

mergify bot commented May 3, 2024

[✅] @mkatychev: Added attachment::Dbg has been merged successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants