Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

downstream error-stack #13

Merged
merged 16 commits into from
Jul 8, 2024
Merged

downstream error-stack #13

merged 16 commits into from
Jul 8, 2024

Conversation

mkatychev
Copy link
Contributor

@mkatychev mkatychev commented Jul 2, 2024 •
edited
Loading

This PR moves the error-stack codebase into a module of bigerror. This opens up a lot of feature work such as:

  • blanket implementations on Report<C> types
  • new methods onto Report<C> and Frame without trait imports
  • simplify naming schemes; ex: attach_printable_lazy -> attach_lazy

NOTE: this is a major breaking change

@mkatychev mkatychev marked this pull request as draft July 2, 2024 16:36
@mergify mergify bot added the feature label Jul 2, 2024
@mkatychev mkatychev marked this pull request as ready for review July 8, 2024 15:57
@mergify mergify bot merged commit 91c529e into main Jul 8, 2024
4 checks passed
@mergify mergify bot deleted the feat/error-stack-downstream branch July 8, 2024 17:56
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 8, 2024

[✅] @mkatychev: downstream error-stack has been merged successfully.

@mergify mergify bot removed the automerge label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gshuflin gshuflin gshuflin approved these changes

Assignees

@mkatychev mkatychev

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkatychev @gshuflin