Skip to content

Conversation

@necobm
Copy link
Contributor

@necobm necobm commented Oct 28, 2025

Removed instruction to enable authenticator manager in README since the option security.enable_authenticator_manager was deprecated since Symfony 6.2 and throws error in Symfony 7.3.

See: scheb/2fa#183

Removed instruction to enable authenticator manager in README since the option security.enable_authenticator_manager was deprecated since Symfony 6.2 and throws error in Symfony 7.3. See: scheb/2fa#183
# ...
+ enable_authenticator_manager: true
# ...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, it could be too aggressive because this bundle still supports legacy Symfony versions ^5.4|^6.0|^7.0 and it may cause problems in legacy versions. How about keeping your changes, but also adding a note below this code block saying something like:

If you have Symfony 6.4 or lower - you will also need to enable the new authenticator manager:

# app/config/packages/security.yaml
security:
    # ...
+   enable_authenticator_manager: true

Could you add this change too?

….4 and lower

Added important note about enabling the authenticator manager for Symfony 6.4 or lower, including configuration example.
Copy link
Member

@bocharsky-bw bocharsky-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@bocharsky-bw bocharsky-bw merged commit 67e4920 into knpuniversity:main Oct 29, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants