added ability to load wasm files from binary#53
Open
brennanjl wants to merge 1 commit intoknqyf263:mainfrom
Open
added ability to load wasm files from binary#53brennanjl wants to merge 1 commit intoknqyf263:mainfrom
brennanjl wants to merge 1 commit intoknqyf263:mainfrom
Conversation
| // versions: | ||
| // protoc-gen-go-plugin v0.1.0 | ||
| // protoc v3.21.12 | ||
| // protoc v3.21.1 |
Collaborator
There was a problem hiding this comment.
nit: use >= version of protoc
dmvolod
reviewed
Jun 12, 2023
|
|
||
| return p.LoadFromBinary(ctx, bytes.NewReader(b), hostFunctions) | ||
| } | ||
| func (p *GreeterPlugin) LoadFromBinary(ctx context.Context, reader io.Reader, hostFunctions HostFunctions) (greeter, error) { |
Contributor
There was a problem hiding this comment.
@brennanjl what do you think about to add (or utilize existence one) a simple test for the LoadFromBinary function?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Issue #52
Description of changes:
io.Reader(previously only supported filepaths).By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.