Test examples#73
Merged
Merged
Conversation
jonathanpallant
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Examples were linted in CI before, but not executed.
Since our examples don't have side-effects or spawn GUIs, etc. we can safely run them too in CI to ensure all the
asserts in them hold true.Should avoid repeats of #72
I chose to add a test case to each example which calls the main function, then tell cargo test to also run tests in example code. (
--all-targetsis very confusing naming. It refers to test targets, not compiler targets).An alternative implementation would be to explicitly
cargo run --example <name>each example in the CI job. There is nocargo run --examples.No changelog entry since this should™ have no effect on the end user.