Skip to content

Minor improvements.#288

Open
uhop wants to merge 9 commits intokoajs:masterfrom
uhop:master
Open

Minor improvements.#288
uhop wants to merge 9 commits intokoajs:masterfrom
uhop:master

Conversation

@uhop
Copy link
Member

@uhop uhop commented Feb 25, 2026

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

@uhop uhop self-assigned this Feb 25, 2026
@codecov
Copy link

codecov bot commented Feb 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (4b8beb2) to head (5b8b7bd).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #288   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          176       175    -1     
  Branches        32        30    -2     
=========================================
- Hits           176       175    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@uhop
Copy link
Member Author

uhop commented Feb 25, 2026

Heh, some module used by c8 has a bug. c8 was newly updated. Let's wait until they fix it.

Yet it WFM locally.

@uhop
Copy link
Member Author

uhop commented Feb 25, 2026

Heh, some module used by c8 has a bug. c8 was newly updated. Let's wait until they fix it.

Yet it WFM locally.

I was able to repro it. It worked with Node 25.6.1, but not with 25.7.0. It clearly a bug of yargs (used by c8).

Relevant bugs:

It looks like c8 was supposed to update dependencies and it didn't relying on the old yargs version. Let's wait for the update. Sigh.

@uhop uhop mentioned this pull request Feb 26, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant