fix(request): return URL origin instead of Origin header#1971
Closed
xxiaoxiong wants to merge 1 commit into
Closed
fix(request): return URL origin instead of Origin header#1971xxiaoxiong wants to merge 1 commit into
xxiaoxiong wants to merge 1 commit into
Conversation
Member
|
see original issue additionally, when making PRs, please make sure you write tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1958
Why
ctx.origin in Koa 3 returns the value of the HTTP Origin request header (via req.headers.origin), which is null for direct browser requests. The expected behavior is to return the URL origin (e.g. http://127.0.0.1:3000), consistent with Koa 2 and the URL.origin specification.
Changes
Changed get origin() in lib/request.js to return this.protocol + :// + this.host instead of this.req.headers.origin || null.
Updated component: lib/request.js
Surface area