Skip to content

deps: update accepts from ^1.3.8 to ^2.0.0 - #1990

Closed
Offwhite-Del wants to merge 1 commit into
koajs:masterfrom
Offwhite-Del:upgrade-accepts-to-v2
Closed

deps: update accepts from ^1.3.8 to ^2.0.0#1990
Offwhite-Del wants to merge 1 commit into
koajs:masterfrom
Offwhite-Del:upgrade-accepts-to-v2

Conversation

@Offwhite-Del

@Offwhite-Del Offwhite-Del commented Jul 19, 2026

Copy link
Copy Markdown

Summary

Upgrade accepts runtime dependency from ^1.3.8 to ^2.0.0.

Motivation

accepts v2 upgrades to negotiator v1 and mime-types v3, bringing the content negotiation stack up to date. The req.accepts*() API is fully backward-compatible.

Koa already uses mime-types ^3.0.1 and type-is ^2.0.1, so accepts v2 aligns the entire content-type stack.

Testing

  • npm install succeeds
  • npm test passes: all passed, 0 failures ✅
  • No source code changes required

Changes

  • package.json: "accepts": "^1.3.8""accepts": "^2.0.0"

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated a package dependency to a newer major version.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 19, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e3d45976-b55e-44c9-b12e-5e9677f173fd

📥 Commits

Reviewing files that changed from the base of the PR and between 52d5e8f and 0a17d89.

📒 Files selected for processing (1)
  • package.json

📝 Walkthrough

Walkthrough

The package manifest updates the accepts dependency version constraint from ^1.3.8 to ^2.0.0. No other package metadata, scripts, or exported declarations are changed.

Suggested reviewers: fengmk2

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely matches the main change: bumping the accepts dependency to ^2.0.0.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Offwhite-Del

Copy link
Copy Markdown
Author

Closing after re-review. accepts@2.0.0 is still published under the next dist-tag, not latest, and this PR does not update the lockfile. GitHub Actions consequently fails at npm ci because the package and lock files are out of sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant