Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #569
Problem
Currently, Kobalte's context menu implementation requires DOM-focused elements owned by the context menu as triggers. This becomes problematic when working with:
Solution
This PR introduces a mechanism to control the context menu from outside its component hierarchy by:
The approach allows developers to:
For example, I use a component like this to expose the context to the parent outside of the root context menu JSX
which is then used something like
Describe alternatives you've considered
We could instead try and hoist all logic and nuance into a state hook above the root context menu node but that would couple all Menu and their child context components together. The solution above allows for us to leverage all existing nuance with minimal code changes.