Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💭 Notes
Fix uv modifications to
pip-compile.sh, updating requirements.txt correctly.Previously,
pip-compile.shwould only print to stdout, and it would not take the existing package versions inrequirements.txtinto consideration. (#6467)The
--output-filefixPass
--output-file(or-o) touv pip compile.Crucially,
--output-filealso acts as an input. Without it, the originalrequirements.txtis ignored, so a lot of packages would get updated instead of staying the same.By naming the output file explicitly, we match
pip-toolsbehavior, which retains existing package versions.# ✅ both act as expected, update corresponding requirements.txt pip-compile requirements.in uv pip compile requirements.in -o requirements.txtCosmetic output differences from uv
Slight change to how this looks:
Some stuff gets moved around (sorted differently):
uv adds this whitespace in the extras list:
More arguments:
--no-strip-extrasand--no-emit-package setuptoolsTo better match
pip compileoutput with what we had already, I added 2 more arguments,--no-strip-extrasand--no-emit-package setuptools.Without these, requirements.txt would differ (aligning with pip-tools >=8).
Mystery addition:
funcsigs==1.0.2viabeginsI'm not sure why uv resolved this and pip-tools didn't:
Perhaps it's not needed…
It appears even if you add
--python-version 3.10.👀 Preview steps
./pip-compile.sh../pip-compile.shwrites toSTDOUTonly./pip-compile.sh. Notice that./pip-compile.sh:dependencies/pip/requirements.txtanddependencies/pip/dev_requirements.txt--upgradeor--upgrade-package <PACKAGE>, or by modifying a pinned version in *.in)requirements.txtanddev_requirements.txt.