Fix LRUCache Swift 6 typecheck#2048
Open
AbodiDawoud wants to merge 1 commit into
Open
Conversation
|
邮件已收到。我会尽快回复！祝您一切顺利！兰雨田
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed the LRU cache playground helper so it typechecks in Swift 6 language mode.
The nested
LinkedListNode<T>generic parameter shadowed the outerLinkedList<T>generic parameter. Newer Swift treats that as an error, so this renames the nested parameter toValuewithout changing behavior.Fixes #964
Checklist
Validation
swiftc -swift-version 6 -typecheck "LRU Cache/LRUCache.playground/Sources/LinkedList.swift" "LRU Cache/LRUCache.swift"swiftc -swift-version 6 -typecheck "LRU Cache/LRUCache.playground/Sources/LinkedList.swift" "LRU Cache/LRUCache.playground/Sources/LRUCache.swift"git diff --checkswiftlintwas not available locally.