Skip to content

chore: update dependency eslint-config-kodefox to v0.2.1 - #351

Open
renovate[bot] wants to merge 4 commits into
masterfrom
renovate/eslint-config-kodefox-0.x
Open

chore: update dependency eslint-config-kodefox to v0.2.1#351
renovate[bot] wants to merge 4 commits into
masterfrom
renovate/eslint-config-kodefox-0.x

Conversation

@renovate

@renovate renovate Bot commented Feb 13, 2020

Copy link
Copy Markdown
Contributor

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
eslint-config-kodefox ^0.2.2 -> ^0.3.0 age adoption passing confidence
eslint-config-kodefox 0.1.0 -> 0.3.0 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate Bot added dependencies Dependencies update ready for review labels Feb 13, 2020
@renovate
renovate Bot force-pushed the renovate/eslint-config-kodefox-0.x branch from 9cbdab0 to 5bc38b2 Compare February 13, 2020 08:20
@darcien darcien added the rebase Tell Renovate to rebase the PR label Feb 13, 2020
@renovate renovate Bot changed the title chore: update dependency eslint-config-kodefox to v0.2.0 chore: update dependency eslint-config-kodefox to v0.2.1 Feb 13, 2020
@renovate renovate Bot removed the rebase Tell Renovate to rebase the PR label Feb 13, 2020
@renovate

renovate Bot commented Feb 13, 2020

Copy link
Copy Markdown
Contributor Author

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

If you think this comment is in error and the branch is not modified, try deleting this comment. If it comes back again the next time Renovate runs, please submit an issue or seek config help.

@darcien

darcien commented Feb 13, 2020

Copy link
Copy Markdown
Contributor

I wonder if the import rule is an overkill if we also specify the order of parent and current dir imports, maybe we just care about the order of the import from packages and from our files.

Especially when this is a lint rule, prettier formatting wont fix it when saving. (We could run eslint --fix, but it's one extra step)

/cc @kodefox/infra

@darcien
darcien force-pushed the renovate/eslint-config-kodefox-0.x branch from 4406484 to 9f1551b Compare February 13, 2020 08:38
@oshimayoan
oshimayoan force-pushed the renovate/eslint-config-kodefox-0.x branch from 9f1551b to f575d88 Compare March 16, 2020 06:22
@oshimayoan

Copy link
Copy Markdown
Contributor

Actually, I don't mind about that as it could force us for better readability. But instead of grouping based on the path parenthesis, I wish it would group the import based on external (all), internal component, internal helper, and internal hooks.

I'll take a look at the library and see if I could change the grouping preference.

/cc @kodefox/infra

@oshimayoan

Copy link
Copy Markdown
Contributor

Here is how my proposal looks like #400.

@oshimayoan
oshimayoan force-pushed the renovate/eslint-config-kodefox-0.x branch from a96a930 to 7a2380f Compare March 26, 2020 03:39
@oshimayoan

Copy link
Copy Markdown
Contributor

Hey @darcien, shall we land this one?

@darcien

darcien commented Mar 26, 2020

Copy link
Copy Markdown
Contributor

Hey @darcien, shall we land this one?

Should we try to land #400 first?

@oshimayoan

Copy link
Copy Markdown
Contributor

Good idea! I'll try to update that one first.

@oshimayoan

Copy link
Copy Markdown
Contributor

As #400 is rejected, shall we land this @darcien?

@darcien

darcien commented Apr 15, 2020

Copy link
Copy Markdown
Contributor

As #400 is rejected, shall we land this @darcien?

Hmm, maybe we should disable module order rule first.

@oshimayoan

Copy link
Copy Markdown
Contributor

Hmm, maybe we should disable module order rule first.

I think our conclusion from #400 is to skip the "additional strictness" from that PR, not from what we have on 0.2.x.

So I'm sure we could land this one.

@renovate

renovate Bot commented Feb 20, 2023

Copy link
Copy Markdown
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dependencies Dependencies update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants