vagrant-wait-for-ip-attribution #204
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Unchecked loops are dangerous 😉 What happens if the IP never comes up? Have you observed how long it may wait here before the IP is valid? I would use a counter and a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this PR:
When provisioning with vagrant in bridge mode, IP address assignment may be delayed. In this case, while provisioning, the host file will be incorrect because the
public-ipcommand will return an empty valueWhat does the PR do:
This PR adds a loop to wait until a valid IP address is assigned before proceeding. This ensures that the public-ip command returns the correct IP and the hosts file is properly configured.