Skip to content

feat:add identifier to plugin. #4289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamsman94 merged 3 commits into from
Sep 15, 2025
Merged

feat:add identifier to plugin. #4289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c4ca6c7
feat:add identifier to plugin.
leozhang2018 Sep 12, 2025
0db8bb1
fix:fix handler.
leozhang2018 Sep 12, 2025
4b06c12
fix:fix filter not update.
leozhang2018 Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/microservice/aslan/core/common/repository/models/plugin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import "go.mongodb.org/mongo-driver/bson/primitive"
type Plugin struct {
ID primitive.ObjectID `bson:"_id,omitempty" json:"id,omitempty"`
Name string `bson:"name" json:"name"`
Identifier string `bson:"identifier" json:"identifier"`
Index int `bson:"index" json:"index"`
Type string `bson:"type" json:"type"` // page or tab
Description string `bson:"description" json:"description"`
Expand Down
1 change: 1 addition & 0 deletions pkg/microservice/aslan/core/common/repository/mongodb/plugin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ func (c *PluginColl) Update(id string, m *models.Plugin) error {
}
change := bson.M{"$set": bson.M{
"name": m.Name,
"identifier": m.Identifier,
"index": m.Index,
"type": m.Type,
"description": m.Description,
Expand Down
22 changes: 22 additions & 0 deletions pkg/microservice/aslan/core/system/handler/plugin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ func CreatePlugin(c *gin.Context) {
ctx.RespErr = e.ErrInvalidParam.AddDesc("name is required")
return
}
args.Identifier = c.PostForm("identifier")
if idxStr := c.PostForm("index"); idxStr != "" {
if parsed, err := strconv.Atoi(idxStr); err == nil {
args.Index = parsed
Expand All @@ -78,6 +79,16 @@ func CreatePlugin(c *gin.Context) {
args.Route = c.PostForm("route")
args.Enabled = c.PostForm("enabled") == "true"

// parse filters if provided
if filtersStr := c.PostForm("filters"); filtersStr != "" {
var filters []*commonmodels.PluginFilter
if err := json.Unmarshal([]byte(filtersStr), &filters); err != nil {
ctx.RespErr = e.ErrInvalidParam.AddDesc("invalid filters format, should be JSON array")
return
}
args.Filters = filters
}

file, header, err := c.Request.FormFile("file")
if err != nil {
ctx.RespErr = e.ErrInvalidParam.AddDesc("file is required")
Expand Down Expand Up @@ -119,6 +130,7 @@ func UpdatePlugin(c *gin.Context) {
}
args := new(commonmodels.Plugin)
args.Name = c.PostForm("name")
args.Identifier = c.PostForm("identifier")
if idxStr := c.PostForm("index"); idxStr != "" {
if parsed, err := strconv.Atoi(idxStr); err == nil {
args.Index = parsed
Expand All @@ -129,6 +141,16 @@ func UpdatePlugin(c *gin.Context) {
args.Route = c.PostForm("route")
args.Enabled = c.PostForm("enabled") == "true"

// parse filters if provided
if filtersStr := c.PostForm("filters"); filtersStr != "" {
var filters []*commonmodels.PluginFilter
if err := json.Unmarshal([]byte(filtersStr), &filters); err != nil {
ctx.RespErr = e.ErrInvalidParam.AddDesc("invalid filters format, should be JSON array")
return
}
args.Filters = filters
}

// try file
file, header, err := c.Request.FormFile("file")
if err == nil {
Expand Down