Skip to content

fix get docker host panic when dind replica is 0 #4308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamsman94 merged 1 commit into from
Sep 25, 2025
Merged

fix get docker host panic when dind replica is 0 #4308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions pkg/microservice/aslan/core/common/service/workflowcontroller/jobcontroller/job_freestyle.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,10 @@ func (c *FreestyleJobCtl) run(ctx context.Context) error {

// decide which docker host to use.
// TODO: do not use code in warpdrive moudule, should move to a public place
dockerhosts := dockerhost.NewDockerHosts(hubServerAddr, c.logger)
c.jobTaskSpec.Properties.DockerHost = dockerhosts.GetBestHost(dockerhost.ClusterID(c.jobTaskSpec.Properties.ClusterID), fmt.Sprintf("%v", c.workflowCtx.TaskID))
if !c.jobTaskSpec.Properties.UseHostDockerDaemon {
dockerhosts := dockerhost.NewDockerHosts(hubServerAddr, c.logger)
c.jobTaskSpec.Properties.DockerHost = dockerhosts.GetBestHost(dockerhost.ClusterID(c.jobTaskSpec.Properties.ClusterID), fmt.Sprintf("%v", c.workflowCtx.TaskID))
}

// not local cluster
var (
Expand Down