Skip to content

Potential fixes for 2 code quality findings #4921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
landylee007 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Potential fixes for 2 code quality findings #4921

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36237a9
Apply suggested fix to pkg/tool/helmclient/helmclient.go from Copilot…
landylee007 Aug 20, 2026
3543717
Apply suggested fix to pkg/tool/helmclient/helmclient.go from Copilot…
landylee007 Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions pkg/tool/helmclient/helmclient.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ func (hClient *HelmClient) upgradeCRDs(ctx context.Context, chartInstance *chart
return nil
}

// upgradeCRDV1Beta1 upgrades a CRD of the v1 API version using the provided k8s client and CRD yaml.
// upgradeCRDV1 upgrades a CRD of the v1 API version using the provided k8s client and CRD yaml.
func (hClient *HelmClient) upgradeCRDV1(ctx context.Context, cl *clientset.Clientset, rawCRD []byte) error {
var crdObj v1.CustomResourceDefinition
if err := yaml.Unmarshal(rawCRD, &crdObj); err != nil {
Expand Down Expand Up @@ -721,8 +721,8 @@ func (hClient *HelmClient) DownloadChart(repoEntry *repo.Entry, chartRef string,
}

pull := action.NewPullWithOpts(action.WithConfig(&action.Configuration{}))
pull.Password = repoEntry.Username
pull.Username = repoEntry.Password
pull.Username = repoEntry.Username
pull.Password = repoEntry.Password
pull.Version = chartVersion
pull.Settings = generalSettings
pull.DestDir = destDir
Expand All @@ -749,8 +749,8 @@ func (hClient *HelmClient) downloadOCIChart(repoEntry *repo.Entry, chartRef stri
return err
}
pull := action.NewPullWithOpts(action.WithConfig(pullConfig))
pull.Password = repoEntry.Username
pull.Username = repoEntry.Password
pull.Username = repoEntry.Username
pull.Password = repoEntry.Password
pull.Version = chartVersion
pull.Settings = generalSettings
pull.DestDir = destDir
Expand Down
Loading