ToDevice(.k) : Set queue_mapping to 0 #360
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somehow, even with only one queue in RX this field is dangling. Fix kohler#359. In ixgbe and i40e that lead to accessing an inexisting queue. Proper support would be to initialize the device with multiple queues, or us multiple ToDevice with a QUEUE argument and use one queue per thread. But that's for another day...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow, even with only one queue in RX this field is dangling to value != 0.
Fix #359 . In ixgbe and i40e that lead to accessing an inexisting queue.
But also probably others.
Proper support would be to initialize the device with multiple queues,
or use multiple ToDevice with a QUEUE argument and use one queue per
thread. But that's for another day...