-
-
Notifications
You must be signed in to change notification settings - Fork 166
Qwen Image Fine Tuning Metadata and Multiple GPU Fine Tuning Fix #668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's a good idea to add arguments to build_metadata just for Qwen-Image-Edit-2509... I'll think about what to do.
| reso = (1280, 720) | ||
| # Use 1328x1328 for Qwen Image models, 1280x720 for others | ||
| if architecture in (ARCHITECTURE_QWEN_IMAGE, ARCHITECTURE_QWEN_IMAGE_EDIT): | ||
| reso = (1328, 1328) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my understanding, isn't the resolution of Qwen-Image-Edit (1024,1024)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the official implementation in Diffusers, it is 1024x1024.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kohya-ss i see. i just updated my pull request to include this new strategy tested it works
e.g.
--meta_arch "qwen-image-edit-plus" --meta_res "512x512"
you can modify delete edit as you wish merge my pull request i just want it to be better :)
and this is super important because i will train qwen image edit model like qwen image base model so i need to provide accurate arch when saving
i will also train 1024x1024 and compare with 1328x1328
|
@kohya-ss i have another proposal can you add 2 args that we can provide arbitrary that will be used when writing metadata? like --meta_res "1328x1328" i prefer this solution i can make pull request for this if you say ok |
If you have multiple features to add, please make multiple pull requests. Edit: Otherwise testing will be difficult. Once this pull request becomes for one feature, I will merge and make some minor fixes, and merge it into the mainline. |
sure thank you so much seperated into 2 pull requests |
This fixes inaccurate metadata of saved Qwen Fine Tuned models
This is massively important @kohya-ss since editing metadata takes massive time on RunPod when using with SwarmUI
I hope you can merge asap
I tested and both resolution and arch fix works auto recognized