Skip to content

fix: adjust block swapping logic for forward-only mode in ModelOffloader #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −2
Draft

fix: adjust block swapping logic for forward-only mode in ModelOffloader #675

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/musubi_tuner/modules/custom_offloading_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,16 @@ def submit_move_blocks_forward(self, blocks: list[nn.Module], block_idx: int):
if not self.forward_only and block_idx >= self.blocks_to_swap:
return

# if forward only, we do not swap blocks in forward pass for the middle blocks
if self.forward_only and (self.blocks_to_swap <= block_idx < self.num_blocks - self.blocks_to_swap):
return

block_idx_to_cpu = block_idx
block_idx_to_cuda = self.num_blocks - self.blocks_to_swap + block_idx
block_idx_to_cuda = block_idx_to_cuda % self.num_blocks # this works for forward-only offloading
if not self.forward_only or block_idx < self.blocks_to_swap:
# move the next block to cuda
block_idx_to_cuda = (self.num_blocks - self.blocks_to_swap + block_idx) % self.num_blocks
else:
# move the previous block to cuda
block_idx_to_cuda = block_idx - (self.num_blocks - self.blocks_to_swap)

self._submit_move_blocks(blocks, block_idx_to_cpu, block_idx_to_cuda)