feat: Support explicit metadata architecture and resolution #683
+48
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding new optional metadata parameters working great
…reso arg for resolution and support Qwen-Image-Edit-Plus natively
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for explicit metadata architecture and resolution configuration, with specific enhancements for the Qwen-Image-Edit-Plus model. The changes allow users to specify custom architecture names and resolutions in model metadata, while providing sensible defaults based on model type.
Key changes:
- Adds
ARCH_QWEN_IMAGE_EDIT_PLUSandCUSTOM_ARCH_QWEN_IMAGE_EDIT_PLUSconstants for distinguishing Edit-Plus variant - Introduces
--metadata_resoand--metadata_archCLI arguments for explicit metadata configuration - Implements architecture-specific default resolutions (1328x1328 for Qwen-Image, 1024x1024 for Qwen-Image-Edit, 1280x720 for others)
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/musubi_tuner/utils/sai_model_spec.py | Adds Edit-Plus architecture constant, custom_arch parameter support, resolution parsing from strings, and architecture-specific resolution defaults |
| src/musubi_tuner/qwen_image_train_network.py | Auto-sets custom_arch when edit_plus mode is enabled |
| src/musubi_tuner/qwen_image_train.py | Passes metadata_reso and metadata_arch to build_metadata, with incorrect is_edit_plus parameter |
| src/musubi_tuner/hv_train_network.py | Adds metadata_reso and metadata_arch CLI arguments and passes them to build_metadata |
| src/musubi_tuner/hv_train.py | Passes metadata_reso and metadata_arch to build_metadata |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
…ng for Edit-Plus mode
…-ss/musubi-tuner into fix-metadata-arch-and-reso
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds Qwen-Image-Edit-Plus supporting for the metadata. Follow up for #673.