Skip to content

Conversation

kohya-ss
Copy link
Owner

closes #2214

@kohya-ss kohya-ss requested a review from Copilot September 29, 2025 11:53
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where the --disable_mmap_load_safetensors argument was not available in SDXL textual inversion training, addressing issue #2214.

  • Enables proper SDXL training argument parsing by calling add_sdxl_training_arguments
  • Standardizes parameter naming from camelCase to snake_case for consistency
  • Updates function calls to use the corrected parameter names

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
sdxl_train_textual_inversion.py Uncomments and fixes the call to add SDXL training arguments, updates parameter naming
library/sdxl_train_util.py Adds conditional parameter support and standardizes naming convention

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@kohya-ss kohya-ss merged commit 206adb6 into main Sep 29, 2025
2 checks passed
@kohya-ss kohya-ss deleted the fix-sdxl-textual-inversion-training-disable-mmap branch September 29, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SDXLでtextual inversionを学習させようとするとエラーが出る

1 participant