Add optional ROS 1/2 bridge utilities #131
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @koide3,
Based on our discussion in Issue #129, I've implemented the following optional ROS bridge utilities.
Summary
This PR adds header-only conversion utilities between ROS messages (
sensor_msgs::PointCloud2/sensor_msgs::msg::PointCloud2) andsmall_gicp::PointCloud.include/small_gicp/ros/ros1.hpp(ROS 1)include/small_gicp/ros/ros2.hpp(ROS 2)include/small_gicp/ros/ros_impl.hpp(Common template implementation)Features
small_gicp's policy of leaving normals/covariances uninitialized until estimation. )Usage Example
Verification
I verified functional correctness, memory safety, and precision. You can easily test the reproduction code and Dockerfiles in the
test/ros-bridgebranch of my fork.