Skip to content

fix: missing primary key; build failure #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

darwintree
Copy link
Contributor

I have met some issues when using the plugin.

  1. missing primary key when adding repos.

It seems that github data format might have changed. The data.id field appeared to be undefined in

await ctx.database.create('github', { name, id: data.id, secret })

It worked when I use data.data.id in place of data.id

  1. typescript build failure

_ctx.request.rawBody would be marked as illegal:

external/github/src/command.ts:267:87 - error TS2339: Property 'rawBody' does not exist on type 'Request'.

267     if (signature !== `sha256=${createHmac('sha256', data.secret).update(_ctx.request.rawBody).digest('hex')}`) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant