Typing and xrandr path #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koiuo
reviewed
Jul 21, 2025
randrctl/xrandr.py
Outdated
| CURRENT_MODE_REGEX = re.compile("\s*(\S+)\s+([0-9\.]+)(.*$)") | ||
|
|
||
| def __init__(self, display: str, xauthority: str): | ||
| def __init__(self, display: Optional[str], xauthority: Optional[str], executable: str = "/usr/bin/xrandr"): |
Owner
There was a problem hiding this comment.
WDYT about alternatively relying on xrandr being in PATH?
If I were writing this today, I'd definitely go with reliance on PATH
Contributor
Author
There was a problem hiding this comment.
I think actually that would solve most of my problem. I'm using it with just "xrandr" so that'd be fine.
Owner
There was a problem hiding this comment.
Would you be willing to make the change to use xrandr from the PATH?
koiuo
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two things:
Xrandrare actually optionalxrandrpath to something elseWill need #39 merging first to fix 3.7