fix: install.sh distrocfg now follows symlinks #764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimWhiting
force-pushed
the
dev
branch
3 times, most recently
from
2c83d90 to
00399ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bundle install script
install.shhangs on Debian for Koka versions v3.1.3 up to v3.2.2, without any output.The issue is in line 114, and occurs because
find /etc/*-release -type fdoesn't output anything, such that we execute justcat.The problem here is that
find -type fonly finds files, whereas on my system,os-releaseis a symlink.This PR applies a simple solution: by adding the
-Loption tofind, it automatically follows symlinks. I've tested this on my system and it works as expected now.