Adjust finalization #783
Open
Adjust finalization #783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Related #510 |
TimWhiting
force-pushed
the
dev
branch
3 times, most recently
from
2c83d90 to
00399ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#780 brought this up.
The parameter/return value for
rcontext.finalizedoes not make much sense in practice.raw ctl'srcontextis intended to escape the handler's return context, and the required parameter makes it awkward to implement cooperative asymmetric coroutines.The other place
Finalizeis used is to ensure finalization ifctlclauses do not resume, in which case the return value is important to keep. Instead of creating a new variant ofFinalizeRaw : resume-context, this PR just casts the return type to().Obviously there are other potential approaches, this probably needs to be discussed more, and a test would need to be added.