add effect type mismatch hints #791
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timbertson
force-pushed
the
effect-diff
branch
2 times, most recently
from
a7e200c to
7af9d0a
Compare
- unexpected effects - missing effects when a skolem fails to unify
timbertson
force-pushed
the
effect-diff
branch
from
7af9d0a to
f322157
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two errors have often come up when I'm writing code, and when there's a lot of effect types it takes a while of scanning the list to figure out the offending effect.
I'm fairly confident about the unexpected effects code path, but the missing effects (and corresponding hint message) was implemented based on finding the codepath I observed for this particular error, rather than a solid understanding of type theory 😅.