Skip to content

fix: streamline mass matrix validation in FlowMCBased class #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Qazalbash merged 1 commit into from
May 28, 2026
Merged

fix: streamline mass matrix validation in FlowMCBased class #835

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 12 additions & 15 deletions src/gwkokab/analysis/core/flowMC_based.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -842,21 +842,18 @@ def driver(
if mass_matrix <= 0.0:
raise LoggedValueError("mass_matrix must be positive")
mass_matrix = jnp.eye(n_dims) * float(mass_matrix)
elif isinstance(mass_matrix, list):
mass_matrix = jnp.array(mass_matrix)
if mass_matrix.ndim > 2:
raise LoggedValueError("mass_matrix must be 1D or 2D array")
_shape = mass_matrix.shape
if _shape != (n_dims, n_dims) and _shape != (n_dims,):
raise LoggedValueError(
f"mass_matrix must be of shape ({n_dims}, {n_dims}) or ({n_dims},), got {_shape}"
)
if _shape == (n_dims,):
if jnp.any(mass_matrix <= 0):
raise LoggedValueError(
"mass_matrix diagonal elements must be positive"
)
mass_matrix = jnp.diag(mass_matrix)

if mass_matrix.ndim > 2:
Comment thread
Qazalbash marked this conversation as resolved.
raise LoggedValueError("mass_matrix must be 1D or 2D array")
_shape = mass_matrix.shape
if _shape != (n_dims, n_dims) and _shape != (n_dims,):
raise LoggedValueError(
f"mass_matrix must be of shape ({n_dims}, {n_dims}) or ({n_dims},), got {_shape}"
)
if _shape == (n_dims,):
if jnp.any(mass_matrix <= 0):
raise LoggedValueError("mass_matrix diagonal elements must be positive")
mass_matrix = jnp.diag(mass_matrix)

bundle = Local_Global_Sampler_Bundle(
rng_key=self.rng_key,
Expand Down
Loading