Skip to content

refactor: add density plotting helper and enhance plot color customization#851

Merged
Qazalbash merged 4 commits into
mainfrom
refactor-marginal-plots
Jun 17, 2026
Merged

refactor: add density plotting helper and enhance plot color customization#851
Qazalbash merged 4 commits into
mainfrom
refactor-marginal-plots

Conversation

@Qazalbash

Copy link
Copy Markdown
Member

No description provided.

@Qazalbash Qazalbash self-assigned this Jun 17, 2026
@Qazalbash Qazalbash added the internal An internal refactor or improvement label Jun 17, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the plotting logic in plot_marginal_with_intervals by extracting it into a new helper function, plot_with_intervals, which plots densities with confidence intervals. The review feedback highlights two key issues: first, mutating the style dictionary arguments directly using .pop() introduces unintended side effects, which can be resolved by copying the dictionaries first; second, the refactoring omitted the ax.set_xlim call, which should be restored to maintain the original x-axis limits.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/gwkokab/analysis/utils/marginals.py Outdated
Comment thread src/gwkokab/analysis/utils/marginals.py
Qazalbash and others added 2 commits June 18, 2026 04:06
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@Qazalbash Qazalbash merged commit 89a76b5 into main Jun 17, 2026
5 checks passed
@Qazalbash Qazalbash deleted the refactor-marginal-plots branch June 17, 2026 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal An internal refactor or improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant