Allow Views of rank > 1 in collective communication operations #181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The semantics used by Tpetra within Trilinos conflict with the limitation that
SendView::rank > 1 not supported/RecvView::rank > 1 not supported. I have removed the two withinsrc/KokkosComm/mpi/allreduce.hppfor my own experimentation replacing MPI with Kokkos Comm in Tpetra. I have also removed the equivalent lines from:src/KokkosComm/mpi/allgather.hppsrc/KokkosComm/mpi/alltoall.hppThis same style has proliferated through the NCCL communication backend (e.g., the corresponding NCCL
allgather). A consensus on the style going forward should be reached. I support removing this limitation.