Skip to content

Conversation

@nicoleavans
Copy link
Contributor

@nicoleavans nicoleavans commented Nov 6, 2025

The semantics used by Tpetra within Trilinos conflict with the limitation that SendView::rank > 1 not supported / RecvView::rank > 1 not supported. I have removed the two within src/KokkosComm/mpi/allreduce.hpp for my own experimentation replacing MPI with Kokkos Comm in Tpetra. I have also removed the equivalent lines from:

  • src/KokkosComm/mpi/allgather.hpp
  • src/KokkosComm/mpi/alltoall.hpp

This same style has proliferated through the NCCL communication backend (e.g., the corresponding NCCL allgather). A consensus on the style going forward should be reached. I support removing this limitation.

@nicoleavans nicoleavans changed the title Pr/rank supported Allow Views of rank > 1 in collective communication operations Nov 6, 2025
@nicoleavans nicoleavans self-assigned this Nov 6, 2025
@nicoleavans nicoleavans marked this pull request as draft November 6, 2025 15:47
@dssgabriel
Copy link
Collaborator

As mentioned during today's meeting, I am in favor of lifting the multi-dimensional constraints on collective operations 🙂
This can be done for both the MPI and NCCL backends; however, we need well-defined semantics for multi-dimensional views, which should be reflected in our documentation.

This will be a very welcome change that broadens the capabilities of KokkosComm!

@nicoleavans nicoleavans marked this pull request as ready for review December 1, 2025 16:10
@nicoleavans nicoleavans removed their assignment Dec 1, 2025
@nicoleavans
Copy link
Contributor Author

Still need to update docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants