Skip to content

Conversation

@marcinwrobel1986
Copy link
Collaborator

@marcinwrobel1986 marcinwrobel1986 commented Aug 29, 2022

THIS PR:

  • API/core/view/view transition from .md to .rst
  • uses cppkokkos
  • screenshots

Issue:

  • maybe we can use cppkokkos:function: for the Constructors part ?
before (.md) after (.rst)
image image
image image
image image
image image
image image
image image
image image
image image
image image

@fnrizzi
Copy link
Collaborator

fnrizzi commented Aug 31, 2022

this needs to be updated again after #108

@fnrizzi
Copy link
Collaborator

fnrizzi commented Aug 31, 2022

@marcinwrobel1986 this is probably the most important one of all, and it is a bit hard to diff the new vs old, can you please upload two zips one with screen snapshots of the new page and one with screen snapshots of the old?

@marcinwrobel1986 marcinwrobel1986 marked this pull request as draft September 1, 2022 17:08
Marcin Wróbel added 2 commits September 5, 2022 13:34
- redefined `host_mirror_space`
- added spaces
- reorganized view types
- modified `Data Access Functions` (possibly missing param `i`)
@marcinwrobel1986 marcinwrobel1986 marked this pull request as ready for review September 5, 2022 12:57
@marcinwrobel1986
Copy link
Collaborator Author

marcinwrobel1986 commented Sep 5, 2022

@fnrizzi I have made the changes accordingly to @crtrott PR
I have noticed some changes made to the old .md file by @masterleinad , but they were a kind of a conflict with latest changes from Christian, so I left the one from PR.

I think that we could add a param i and describe it - between line 289 and 291.

@fnrizzi fnrizzi marked this pull request as draft September 12, 2022 12:39
@antoinemeyer5 antoinemeyer5 marked this pull request as ready for review February 15, 2023 14:22
@fnrizzi fnrizzi mentioned this pull request Feb 19, 2023
@fnrizzi
Copy link
Collaborator

fnrizzi commented Feb 19, 2023

superseeded by #296

@fnrizzi fnrizzi closed this Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants