Skip to content

Conversation

@antoinemeyer5
Copy link
Contributor

@antoinemeyer5 antoinemeyer5 commented Feb 21, 2023

THIS PR:

  • API/core/stl_compat/pair transition from .md to .rst
  • uses cppkokkos
  • rebased on latest main
  • screenshots

issue:

  • weird color for line function 62
    image
    Here is the warning
before (.md) after (.rst)
image image
image image

Copy link
Collaborator

@fnrizzi fnrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antoinemeyer5

  1. please remote the synopsis
  2. please document the class properly using cppkokkos, right now it is a mix of blocks and things. Look at this: #312 , follow a similar format

@antoinemeyer5 antoinemeyer5 requested a review from fnrizzi March 2, 2023 09:42
@fnrizzi fnrizzi marked this pull request as draft March 2, 2023 13:53
@antoinemeyer5
Copy link
Contributor Author

antoinemeyer5 commented Jun 8, 2023

I always get error messages.

Here are 3 examples that work and the result we'd like to have that doesn't:

image

What should I do now @fnrizzi?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants