Skip to content

Conversation

@romintomasetti
Copy link
Contributor

@romintomasetti romintomasetti commented Apr 1, 2025

Summary

We are starting to document Kokkos::Experimental::Graph.

This PR sets the basement for it.

Joint work with @maartenarnst.

Drive-by change: ensure that the year corresponds to the moment the documentation was generated. (see #649)

Description

Some additional work was need to get graphviz working:

  1. apt install the graphviz package
  2. but the CI was running on a runner, not in a container, so I got permission denied
  3. so I added container:
  4. and pip was not found
  5. so I ended up using the python:3.10 image.

Related

@romintomasetti romintomasetti requested a review from JBludau April 1, 2025 16:12
@romintomasetti romintomasetti self-assigned this Apr 1, 2025
@romintomasetti
Copy link
Contributor Author

romintomasetti commented Apr 2, 2025

As discussed with @dalg24, let's give the Kokkos::Graph a decent minimal amount of documentation.

@dalg24 @JBludau @crtrott Would you have some time to review this ?

@romintomasetti romintomasetti changed the title core(graph): placeholder core(graph): initial doc Apr 2, 2025
Copy link
Contributor

@JBludau JBludau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a good starting point

@romintomasetti
Copy link
Contributor Author

@dalg24 Would you mind taking a look ? 👓

@dalg24
Copy link
Member

dalg24 commented Apr 4, 2025

It is fine to add later but we also will need the API reference for it

Copy link
Contributor

@maartenarnst maartenarnst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK indeed!

@dalg24 dalg24 merged commit 32d75a9 into kokkos:main Apr 7, 2025
3 checks passed
@romintomasetti romintomasetti deleted the graph-start branch April 8, 2025 11:49
diehlpk pushed a commit to diehlpk/kokkos-core-wiki that referenced this pull request Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants