Skip to content

Conversation

@nmm0
Copy link
Contributor

@nmm0 nmm0 commented Apr 24, 2025

Supersedes #671 because I accidentally made a PR not from my fork 🤷

Copy link
Contributor

@romintomasetti romintomasetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am really unconvinced by the necessity to explain how one can get Python.

How the developer should get Python is not part of this repository. To me, only the minimum Python version would be worth writing here.

Requirements are in `build_requirements.txt`
Could be installed with: `pip install -r build_requirements.txt`

We recommend using a virtual environment, e.g. if your system python is >= 3.12:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor point. It is better to capitalized Python when it is referred to as a proper noun. Lines 6 and 11.

@dalg24
Copy link
Member

dalg24 commented Apr 25, 2025

No opinion on how to get Python. I think that the suggestion to use venv with a short snippet the people can just copy and paste is a good addition though,

@nmm0
Copy link
Contributor Author

nmm0 commented Apr 28, 2025

I am really unconvinced by the necessity to explain how one can get Python.

How the developer should get Python is not part of this repository. To me, only the minimum Python version would be worth writing here.

I'd agree if this was more outwards facing. I added this instruction mainly for the benefit of others in the Kokkos team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants