-
Notifications
You must be signed in to change notification settings - Fork 60
Deprecate View::HostMirror in favor of View::host_mirror_type #706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
e3a4d16 to
ab6c52f
Compare
masterleinad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be probbaly be good to at least mention that HostMirror exists as deprecated alias.
|
We have this wiki page to document deprecations[1]. |
I think it this would be fine. Can we somehow change the search order on the wiki so the deprecation page gets hit first? |
|
|
Annoying but you need two more |
ab6c52f to
0418ec0
Compare
| this :cpp:class:`View` type with :cpp:type:`const_data_type` passed as the :cpp:any:`DataType` template parameter | ||
|
|
||
| .. cpp:type:: HostMirror | ||
| .. cpp:type:: host_mirror_type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't HostMirror still be listed as a deprecated type? And host_mirror_type should have something like "since 4.7.0"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I support that, as expressed in #706 (comment)
Signed-off-by: Jan Ciesko <[email protected]>
|
I've noticed that we have deprecation macros. I've updated the PR. |
Co-authored-by: Daniel Arndt <[email protected]>
Co-authored-by: Daniel Arndt <[email protected]>
Co-authored-by: Daniel Arndt <[email protected]>
Co-authored-by: Daniel Arndt <[email protected]>
Signed-off-by: Jan Ciesko <[email protected]>
kokkos/kokkos#8232