Skip to content

Conversation

@janciesko
Copy link
Contributor

@janciesko janciesko requested a review from JBludau August 4, 2025 19:53
Copy link
Contributor

@masterleinad masterleinad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be probbaly be good to at least mention that HostMirror exists as deprecated alias.

@janciesko
Copy link
Contributor Author

We have this wiki page to document deprecations[1].
Let's document this change there instead?

[1] https://kokkos.org/kokkos-core-wiki/deprecations.html

@JBludau
Copy link
Contributor

JBludau commented Aug 5, 2025

We have this wiki page to document deprecations[1]. Let's document this change there instead?

[1] https://kokkos.org/kokkos-core-wiki/deprecations.html

I think it this would be fine. Can we somehow change the search order on the wiki so the deprecation page gets hit first?

@janciesko
Copy link
Contributor Author

janciesko commented Aug 5, 2025

Ok, adding deprecation info to https://kokkos.org/kokkos-core-wiki/deprecations.html
I'll add this once we know when we're releasing the related deprecations. I am ok to wait with the PR.

@nmm0
Copy link
Contributor

nmm0 commented Aug 5, 2025

 Deep copy and host mirror
~~~~~~~~~~~~~~~~~~~~~~~~ [docutils]
/__w/kokkos-core-wiki/kokkos-core-wiki/docs/source/ProgrammingGuide/View.rst:514: WARNING: Title underline too short.

Annoying but you need two more ~

this :cpp:class:`View` type with :cpp:type:`const_data_type` passed as the :cpp:any:`DataType` template parameter

.. cpp:type:: HostMirror
.. cpp:type:: host_mirror_type
Copy link
Member

@crtrott crtrott Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't HostMirror still be listed as a deprecated type? And host_mirror_type should have something like "since 4.7.0"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support that, as expressed in #706 (comment)

Signed-off-by: Jan Ciesko <[email protected]>
@janciesko
Copy link
Contributor Author

I've noticed that we have deprecation macros. I've updated the PR.

Signed-off-by: Jan Ciesko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants