Lapack geqrf #2858
Draft
Lapack geqrf #2858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wrappers will allow use of LAPACK, cusolver, rocsolver and magma Signed-off-by: Luc Berger-Vergiat <[email protected]>
Signed-off-by: Luc Berger-Vergiat <[email protected]>
Signed-off-by: Luc Berger-Vergiat <[email protected]>
jgfouca
requested changes
Nov 13, 2025
Contributor
jgfouca
left a comment
jgfouca
left a comment
There was a problem hiding this comment.
Looks good. Just a few minor things.
| static_assert(std::is_same_v<typename InfoArray::non_const_value_type, int>, | ||
| "KokkosLapack::geqrf: Info must be an array of integers."); | ||
|
|
||
| int64_t m = A.extent(0); |
Contributor
There was a problem hiding this comment.
These could all be consts.
| for (int index(k + 1); index < m; ++index) { | ||
| h_v[index] = h_A(index, k); | ||
| } | ||
| #if 0 // def HAVE_KOKKOSKERNELS_DEBUG |
Contributor
There was a problem hiding this comment.
Is it worthwhile to keep these #if 0 blocks around? Should we switch these to something like #if QEQRF_DEBUG so that the programmer can turn these all back on easily?
| /// Geqrf | ||
| /// | ||
|
|
||
| void F77_BLAS_MANGLE(sgeqrf, SGEQRF)(int*, int*, float*, int*, float*, float*, int*, int*); |
Contributor
There was a problem hiding this comment.
I noticed none of these are consts. Is every argument an output or inout?
Signed-off-by: Luc Berger-Vergiat <[email protected]>
Signed-off-by: Luc Berger-Vergiat <[email protected]>
Signed-off-by: Luc Berger-Vergiat <[email protected]>
Signed-off-by: Luc Berger-Vergiat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking over PR #2205 rebasing on the current state of develop and re-running tests, will also have a look at the unit-tests and might add more checks.